Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced pictures for fan box #133

Closed
wants to merge 2 commits into from
Closed

Conversation

Venkat4real
Copy link
Collaborator

Continuation of #125

@Venkat4real Venkat4real added the documentation Improvements or additions to documentation label Apr 9, 2024
@Venkat4real Venkat4real added this to the 2024 Makerfaire milestone Apr 9, 2024
Copy link
Collaborator

@mmroden mmroden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes


| Weather Guard
| P-TET-000143
| 1
| PLA/PETG
| No
| https://github.com/tetrabiodistributed/papr-print-files/blob/f77c5bc3c5f0d8fadfdf2757c59a09a8cd5e584b/STLs/fan_box/96mm%20Stealth%20Parts/P-TET-000159%20Stealth%20Filter%20Frame%20Sanyo.stl
| https://github.com/tetrabiodistributed/papr-print-files/blob/f77c5bc3c5f0d8fadfdf2757c59a09a8cd5e584b/STLs/fan_box/96mm%20Stealth%20Parts/P-TET-000159%20Stealth%20Filter%20Frame%20Sanyo.stl[STL]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -43,77 +43,77 @@ These parts should be printed at 0.2 or 0.15 spacing. They should be oriented s
| 1
| PLA/PETG
| No (Can have some in the nut pocket)
| https://github.com/tetrabiodistributed/papr-print-files/blob/f77c5bc3c5f0d8fadfdf2757c59a09a8cd5e584b/STLs/fan_box/96mm%20Stealth%20Parts/P-TET-000140%20Base%20Sanyo.st
| https://github.com/tetrabiodistributed/papr-print-files/blob/f77c5bc3c5f0d8fadfdf2757c59a09a8cd5e584b/STLs/fan_box/96mm%20Stealth%20Parts/P-TET-000140%20Base%20Sanyo.st[STL]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link should end with .stl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Venkat4real this link needs to fixing still

@@ -167,22 +167,22 @@ These are components that need to be purchased. Prices fluctuate, and so are no
| Count | Description | URL | Number in Package
| 1
| Sanyo Denki 9BMB12F201
| https://octopart.com/9bmb12f201-sanyo+denki-24320259
| https://octopart.com/9bmb12f201-sanyo+denki-24320259[Link]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to the main electronics BOM? I don't think this is the right fan, but maybe it is. I thought it ended with 202 not 201

@Burhan-Q
Copy link
Member

@Venkat4real looks like there's a few fixes needed, but once addressed this can be merged.

@@ -43,77 +43,77 @@ These parts should be printed at 0.2 or 0.15 spacing. They should be oriented s
| 1
| PLA/PETG
| No (Can have some in the nut pocket)
| https://github.com/tetrabiodistributed/papr-print-files/blob/f77c5bc3c5f0d8fadfdf2757c59a09a8cd5e584b/STLs/fan_box/96mm%20Stealth%20Parts/P-TET-000140%20Base%20Sanyo.st
| https://github.com/tetrabiodistributed/papr-print-files/blob/f77c5bc3c5f0d8fadfdf2757c59a09a8cd5e584b/STLs/fan_box/96mm%20Stealth%20Parts/P-TET-000140%20Base%20Sanyo.st[STL]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Venkat4real this link needs to fixing still

| 1

| 1
|Stealth Filters
|https://www.amazon.com/STEALTH-Respirator-Filters-Woodworking-Replacement/dp/B09H52LGGW[Stealth Filters]
|https://www.amazon.com/STEALTH-Respirator-Filters-Woodworking-Replacement/dp/B09H52LGGW[link]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make [Link] (capitalized "L") for consistency

@Venkat4real
Copy link
Collaborator Author

Closing this PR because the changes are made in the last PR.

@capsulecorplab capsulecorplab deleted the update-mask-assembly-page branch July 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants